Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Picture-In-Picture] Expose some APIs behind a runtime feature. #9196

Merged
merged 1 commit into from Jan 31, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 25, 2018

https://wicg.github.io/picture-in-picture/

The API is currently not working. It is mostly about implementing the shell: it
exposes document.pictureInPictureEnabled, document.exitPictureInPicture(), and
video.requestPictureInPicture(). It also adds the "picture-in-picture" feature
policy. Everything is gated by the "PictureInPictureAPI" runtime feature.

Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/U8Apo-WLBm4/03sO4ITYAQAJ

Change-Id: I64d8e17c6975017565c850afeeca19d94e9f9ceb
Bug: 806249
Reviewed-on: https://chromium-review.googlesource.com/867915
Commit-Queue: Mounir Lamouri (slow) mlamouri@chromium.org
Reviewed-by: Mounir Lamouri (slow) mlamouri@chromium.org
Reviewed-by: Mike West mkwst@chromium.org
Reviewed-by: Ian Clelland iclelland@chromium.org
Reviewed-by: Kentaro Hara haraken@chromium.org
Cr-Commit-Position: refs/heads/master@{#533310}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 25, 2018

Build PASSED

Started: 2018-01-31 17:44:10
Finished: 2018-01-31 17:51:38

Failing Jobs

  • MicrosoftEdge:14.14393
  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/feature-policy/picture-in-picture-allowed-by-feature-policy.https.sub.html   TIMEOUT: 1
ERROR: 9
  Feature-Policy header: picture-in-picture * allows cross-origin iframes. TIMEOUT: 9
Test timed out
  Feature-Policy header: picture-in-picture * allows same-origin iframes. TIMEOUT: 9
Test timed out
  Feature-Policy header: picture-in-picture * allows the top-level document. TIMEOUT: 9
Test timed out
/feature-policy/picture-in-picture-default-feature-policy.https.sub.html   TIMEOUT: 2
ERROR: 8
  Default "picture-in-picture" feature policy ["self"] allows same-origin iframes. TIMEOUT: 8
Test timed out
  Default "picture-in-picture" feature policy ["self"] allows the top-level document. TIMEOUT: 8
Test timed out
  Default "picture-in-picture" feature policy ["self"] disallows cross-origin iframes. TIMEOUT: 8
Test timed out

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-867915 branch 2 times, most recently from 2dfd466 to 61aeb77 Jan 25, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [Picture-In-Picture] Add Web API [Picture-In-Picture] Expose some APIs behind a runtime feature. Jan 26, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-867915 branch 10 times, most recently from db6f8ad to a0f1d35 Jan 26, 2018

[Picture-In-Picture] Expose some APIs behind a runtime feature.
https://wicg.github.io/picture-in-picture/

The API is currently not working. It is mostly about implementing the shell: it
exposes document.pictureInPictureEnabled, document.exitPictureInPicture(), and
video.requestPictureInPicture(). It also adds the "picture-in-picture" feature
policy. Everything is gated by the "PictureInPictureAPI" runtime feature.

Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/U8Apo-WLBm4/03sO4ITYAQAJ

Change-Id: I64d8e17c6975017565c850afeeca19d94e9f9ceb
Bug: 806249
Reviewed-on: https://chromium-review.googlesource.com/867915
Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri (slow) <mlamouri@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533310}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-867915 branch from a0f1d35 to b47854f Jan 31, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 990e1c8 into master Jan 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-867915 branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.