Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SauceConnect when the proxy fails in various ways #9201

Merged

Conversation

Projects
None yet
4 participants
@gsnedders
Copy link
Contributor

gsnedders commented Jan 25, 2018

I still don't like the sleep loop; suggestions welcome!


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Jan 25, 2018

@wpt-pr-bot wpt-pr-bot requested a review from jgraham Jan 25, 2018

if self.sc_process.returncode is not None and self.sc_process.returncode > 0:
tot_wait = 0
while not os.path.exists('./sauce_is_ready') and self.sc_process.poll() is None:
time.sleep(5)

This comment has been minimized.

Copy link
@jgraham

jgraham Jan 25, 2018

Contributor

Put this in a variable and use it n your counter.

This comment has been minimized.

Copy link
@gsnedders

gsnedders Jan 25, 2018

Author Contributor

Does this look better now?

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 25, 2018

Build PASSED

Started: 2018-01-25 23:15:27
Finished: 2018-01-25 23:30:22

View more information about this build on:

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Jan 25, 2018

23:20 < jgraham> gsnedders: Happy for you to land if you want

So, squash & merge when CI completes.

@gsnedders gsnedders merged commit 9838110 into web-platform-tests:master Jan 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the gsnedders:sauce_connect_error_handling branch Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.