Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Server creation for localhost #9202

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
5 participants
@thejohnjansen
Copy link
Contributor

thejohnjansen commented Jan 26, 2018

In my last change, I missed this line of code. Adding the host parameter and removing the base_path param.


This change is Reviewable

Updating Server creation for localhost
In my last change, I missed this line of code. Adding the host parameter and removing the base_path param.

@wpt-pr-bot wpt-pr-bot added the infra label Jan 26, 2018

@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jgraham Jan 26, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 26, 2018

Build PASSED

Started: 2018-01-26 01:07:55
Finished: 2018-01-26 01:22:41

View more information about this build on:

@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Feb 5, 2018

Why does this have to be localhost not 127.0.0.1?

@thejohnjansen

This comment has been minimized.

Copy link
Contributor Author

thejohnjansen commented Feb 6, 2018

@jgraham : I should have included it in my initial PR. It's because of a feature missing in our webdriver. Same thing goes for IEDriver, which is why that one matches the Edge code. https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/3901350/

@thejohnjansen

This comment has been minimized.

Copy link
Contributor Author

thejohnjansen commented Feb 15, 2018

@gsnedders and @jgraham Anything else to do here? I keep having to send this url to people who are trying to run these tests... :-)

@gsnedders gsnedders merged commit 09ca41d into master Feb 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Feb 15, 2018

@thejohnjansen I was waiting for @jgraham given he has more of an idea about this. :)

@gsnedders gsnedders deleted the johnjansenEdgeFix branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.