Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] fallback attribute should be readonly attribute #9203

Merged
merged 1 commit into from Jan 27, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 26, 2018

According to below linked issue(#514), CSSVariableReferenceValue
should have a constructor.
and also fallback attribute should be readonly attribute.
constructor was already added in chromium. but readonly keyword
was not added. so add readonly keyword for fallback attribute.
(actually it is related with #513 to add readonly keyword)

w3c/css-houdini-drafts#547
w3c/css-houdini-drafts#514
w3c/css-houdini-drafts#513

Bug: 803687
Change-Id: I91b5d4f21b75cd5d27063bfceba0b39b30977be9
Reviewed-on: https://chromium-review.googlesource.com/881381
Reviewed-by: Darren Shen shend@chromium.org
Commit-Queue: Hwanseung Lee hs1217.lee@samsung.com
Cr-Commit-Position: refs/heads/master@{#532167}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 26, 2018

Build PASSED

Started: 2018-01-27 06:07:28
Finished: 2018-01-27 06:11:48

View more information about this build on:

[css-typed-om] fallback attribute should be readonly attribute
According to below linked issue(#514), CSSVariableReferenceValue
should have a constructor.
and also fallback attribute should be readonly attribute.
constructor was already added in chromium. but readonly keyword
was not added. so add readonly keyword for fallback attribute.
(actually it is related with #513 to add readonly keyword)

w3c/css-houdini-drafts#547
w3c/css-houdini-drafts#514
w3c/css-houdini-drafts#513

Bug: 803687
Change-Id: I91b5d4f21b75cd5d27063bfceba0b39b30977be9
Reviewed-on: https://chromium-review.googlesource.com/881381
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#532167}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-881381 branch from 652bce0 to f710d75 Jan 27, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f99729c into master Jan 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-881381 branch Jan 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.