Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support calc() in font-feature-settings #9204

Merged
merged 1 commit into from Jan 27, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 26, 2018

font-feature-settings accepts an integer, but the code for parsing that
integer did not check for calc() values. Update the code to accept
calculated integers.

Bug: 397061
Change-Id: I33ed1538f8148257f22a3e67cbd3478e523a1ff5
Reviewed-on: https://chromium-review.googlesource.com/888161
Reviewed-by: Eric Willigers ericwilligers@chromium.org
Commit-Queue: Chris Nardi cnardi@chromium.org
Cr-Commit-Position: refs/heads/master@{#532158}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 26, 2018

Build PASSED

Started: 2018-01-27 05:00:32
Finished: 2018-01-27 05:04:52

View more information about this build on:

Support calc() in font-feature-settings
font-feature-settings accepts an integer, but the code for parsing that
integer did not check for calc() values. Update the code to accept
calculated integers.

Bug: 397061
Change-Id: I33ed1538f8148257f22a3e67cbd3478e523a1ff5
Reviewed-on: https://chromium-review.googlesource.com/888161
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532158}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-888161 branch from 3ded66e to 128c580 Jan 27, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 82a6875 into master Jan 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-888161 branch Jan 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.