Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with HTML Standard getContext() changes #9205

Merged
merged 1 commit into from Jan 31, 2018

Conversation

Projects
None yet
4 participants
@annevk
Copy link
Member

annevk commented Jan 26, 2018

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Jan 26, 2018

annevk added a commit to whatwg/html that referenced this pull request Jan 26, 2018

Simplify getContext() and make it throw less
In practice getContext() only has two arguments. And in practice some
handling of the second argument is shared across the various rendering
context types. This aligns the standard with that practice.

This also obviates the need for dedicated coercion algorithms for "2d"
and "bitmaprender".

This change also fixes various minor nits found along the way, such as
the inconsistent spelling of contextId (was sometimes contextType).

Tests: web-platform-tests/wpt#9194 and
web-platform-tests/wpt#9205.

Fixes #595.
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 26, 2018

Build PASSED

Started: 2018-01-26 08:02:21
Finished: 2018-01-26 08:15:29

This report has been truncated because the number of unstable tests exceeds GitHub.com's character limit for comments (65536 characters).

Failing Jobs

  • MicrosoftEdge:14.14393
  • safari:11.0

Unstable Browsers

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

@annevk annevk requested a review from foolip Jan 31, 2018

@foolip

foolip approved these changes Jan 31, 2018

@annevk annevk merged commit c0a34a2 into master Jan 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the annevk/getContext-changes branch Jan 31, 2018

alice added a commit to alice/html that referenced this pull request Jan 8, 2019

Simplify getContext() and make it throw less
In practice getContext() only has two arguments. And in practice some
handling of the second argument is shared across the various rendering
context types. This aligns the standard with that practice.

This also obviates the need for dedicated coercion algorithms for "2d"
and "bitmaprender".

This change also fixes various minor nits found along the way, such as
the inconsistent spelling of contextId (was sometimes contextType).

Tests: web-platform-tests/wpt#9194 and
web-platform-tests/wpt#9205.

Fixes whatwg#595.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.