Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createImageBitmap() and zero width/height image sources #9207

Merged
merged 1 commit into from Jan 26, 2018

Conversation

Projects
None yet
4 participants
@annevk
Copy link
Member

annevk commented Jan 26, 2018

Helps with whatwg/html#3399.

@annevk annevk requested review from Ms2ger and junov Jan 26, 2018

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Jan 26, 2018

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@annevk

This comment has been minimized.

Copy link
Member Author

annevk commented Jan 26, 2018

I could do more deduplication I suppose and make a little array of paths and for each them? Up to you.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 26, 2018

Build PASSED

Started: 2018-01-26 15:44:51
Finished: 2018-01-26 15:55:58

Failing Jobs

  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/2dcontext/imagebitmap/createImageBitmap-invalid-args.html   TIMEOUT: 4
OK: 6
  createImageBitmap with a a Blob source and oversized (unallocatable) crop region FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a a Blob source and sh set to 0 FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a a Blob source and sw set to 0 FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an HTMLCanvasElement source and oversized (unallocatable) crop region FAIL: 8
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an HTMLCanvasElement source and sh set to 0 FAIL: 8
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an HTMLCanvasElement source and sw set to 0 FAIL: 8
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an HTMLImageElement source and oversized (unallocatable) crop region FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an HTMLImageElement source and sh set to 0 FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an HTMLImageElement source and sw set to 0 FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an HTMLVideoElement source and oversized (unallocatable) crop region FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an HTMLVideoElement source and sh set to 0 TIMEOUT: 1
FAIL: 6
NOTRUN: 1
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
Test timed out
  createImageBitmap with a an HTMLVideoElement source and sw set to 0 TIMEOUT: 1
FAIL: 7
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
Test timed out
  createImageBitmap with a an ImageBitmap source and oversized (unallocatable) crop region FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an ImageBitmap source and sh set to 0 FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an ImageBitmap source and sw set to 0 FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an ImageData source and oversized (unallocatable) crop region FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an ImageData source and sh set to 0 FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an ImageData source and sw set to 0 FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a an OffscreenCanvas source and oversized (unallocatable) crop region FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: OffscreenCanvas"
  createImageBitmap with a an OffscreenCanvas source and sh set to 0 FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: OffscreenCanvas"
  createImageBitmap with a an OffscreenCanvas source and sw set to 0 FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: OffscreenCanvas"
  createImageBitmap with a broken image source. FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with a closed ImageBitmap. FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with an available but undecodable image source. FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with an available but zero height image source. FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with an available but zero width image source. FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with an invalid OffscreenCanvas source. FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: OffscreenCanvas"
  createImageBitmap with an oversized canvas source. FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with an undecodable blob source. FAIL: 6
NOTRUN: 2
promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: createImageBitmap"
  createImageBitmap with empty image source. FAIL: 6
NOTRUN: 2
Can't find variable: createImageBitmap
  createImageBitmap with empty video source. FAIL: 6
NOTRUN: 2
Can't find variable: createImageBitmap
  createImageBitmap with null image source. FAIL: 6
NOTRUN: 2
Can't find variable: createImageBitmap
  createImageBitmap with undefined image source. FAIL: 6
NOTRUN: 2
Can't find variable: createImageBitmap

annevk added a commit to whatwg/html that referenced this pull request Jan 26, 2018

Make createImageBitmap() share more logic
In particular, with createPattern() and drawImage().

Tests: web-platform-tests/wpt#9207.
@junov

junov approved these changes Jan 26, 2018

annevk added a commit to whatwg/html that referenced this pull request Jan 26, 2018

Make createImageBitmap() share more logic
In particular, with createPattern() and drawImage().

Tests: web-platform-tests/wpt#9207.

annevk added a commit to whatwg/html that referenced this pull request Jan 26, 2018

Make createImageBitmap() share more logic
In particular, with createPattern() and drawImage().

Tests: web-platform-tests/wpt#9207.

Fixes #3399.

@annevk annevk merged commit 89ffe5b into master Jan 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the annevk/createImageBitmap-zero-width-height branch Jan 26, 2018

annevk added a commit to whatwg/html that referenced this pull request Jan 29, 2018

Make createImageBitmap() share more logic
In particular, with createPattern() and drawImage().

Tests: web-platform-tests/wpt#9207.

Fixes #3399.

alice added a commit to alice/html that referenced this pull request Jan 8, 2019

Make createImageBitmap() share more logic
In particular, with createPattern() and drawImage().

Tests: web-platform-tests/wpt#9207.

Fixes whatwg#3399.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.