Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollIntoView() should take scroll-padding into account #9210

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 26, 2018

According to the spec, https://www.w3.org/TR/css-scroll-snap-1/,
:target/scrollIntoView()/etc should take scroll-margin, into account.

This patch also unifies the logic of ScrollIntoView() in PaintLayerScrollableArea,
LocalFrameView and RootFrameViewport, so that the new_scroll_offset is calcultated
directly by ScrollAlignment::GetScrollOffsetToExpose()

Bug: 803606
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie790bc58f7dcc0a2744768ddca0d07b24bbf6681
Reviewed-on: https://chromium-review.googlesource.com/875008
Reviewed-by: Jeremy Roman jbroman@chromium.org
Reviewed-by: David Bokan bokan@chromium.org
Commit-Queue: Sandra Sun sunyunjia@chromium.org
Cr-Commit-Position: refs/heads/master@{#532660}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 26, 2018

Build PASSED

Started: 2018-01-30 00:06:23
Finished: 2018-01-30 00:11:37

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-875008 branch 3 times, most recently from 7167bcb to 4066b83 Jan 28, 2018

ScrollIntoView() should take scroll-padding into account
According to the spec, https://www.w3.org/TR/css-scroll-snap-1/,
:target/scrollIntoView()/etc should take scroll-margin, into account.

This patch also unifies the logic of ScrollIntoView() in PaintLayerScrollableArea,
LocalFrameView and RootFrameViewport, so that the new_scroll_offset is calcultated
directly by ScrollAlignment::GetScrollOffsetToExpose()

Bug: 803606
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie790bc58f7dcc0a2744768ddca0d07b24bbf6681
Reviewed-on: https://chromium-review.googlesource.com/875008
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532660}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-875008 branch from 4066b83 to 8508cda Jan 29, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e0d3be7 into master Jan 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-875008 branch Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.