Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double-quotes when serializing font-feature-settings #9211

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 27, 2018

According to the CSSOM spec
(https://drafts.csswg.org/cssom/#common-serializing-idioms), all
strings should be serialized with double-quotes. The feature tag value
was previously serialized with single-quotes; change this to
double-quotes to match the spec and non-WebKit browsers.

Bug: 806412
Change-Id: I5a93cc6add285aff46184c238b180e7617750702
Reviewed-on: https://chromium-review.googlesource.com/889909
Commit-Queue: Chris Nardi cnardi@chromium.org
Reviewed-by: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#532298}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 27, 2018

Build PASSED

Started: 2018-01-29 01:35:10
Finished: 2018-01-29 01:39:56

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-889909 branch from e3b9010 to 9fbc5ca Jan 28, 2018

Use double-quotes when serializing font-feature-settings
According to the CSSOM spec
(https://drafts.csswg.org/cssom/#common-serializing-idioms), all
strings should be serialized with double-quotes. The feature tag value
was previously serialized with single-quotes; change this to
double-quotes to match the spec and non-WebKit browsers.

Bug: 806412
Change-Id: I5a93cc6add285aff46184c238b180e7617750702
Reviewed-on: https://chromium-review.googlesource.com/889909
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532298}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-889909 branch from 9fbc5ca to 6f90846 Jan 29, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 610207c into master Jan 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-889909 branch Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.