Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ::slotted() never match <slot> elements. #9212

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 27, 2018

According to the css-scoping spec, ::slotted() matches flattened
slotables. Slot elements which are assigned to other slots are not part
of the flattened slotables. The test currently fails because slots are
not included in the flat tree.

Bug: 660265
Change-Id: Ifbcb03d3212db59d762d173a221382ed79ccbd0e
Reviewed-on: https://chromium-review.googlesource.com/887950
Reviewed-by: Hayato Ito hayato@chromium.org
Commit-Queue: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/heads/master@{#532335}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 27, 2018

Build PASSED

Started: 2018-01-29 06:52:01
Finished: 2018-01-29 06:58:02

Failing Jobs

  • MicrosoftEdge:14.14393

View more information about this build on:

emilio added a commit to emilio/servo that referenced this pull request Jan 27, 2018

emilio added a commit to emilio/servo that referenced this pull request Jan 27, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-887950 branch from 5e0c05b to 4d3c7bc Jan 29, 2018

Make ::slotted() never match <slot> elements.
According to the css-scoping spec, ::slotted() matches flattened
slotables. Slot elements which are assigned to other slots are not part
of the flattened slotables. The test currently fails because slots are
not included in the flat tree.

Bug: 660265
Change-Id: Ifbcb03d3212db59d762d173a221382ed79ccbd0e
Reviewed-on: https://chromium-review.googlesource.com/887950
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532335}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-887950 branch from 4d3c7bc to 2d55bd2 Jan 29, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6de4c56 into master Jan 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-887950 branch Jan 29, 2018

bors-servo added a commit to servo/servo that referenced this pull request Jan 29, 2018

Auto merge of #19878 - emilio:slotted-slot, r=nox
selectors: Never match ::slotted on <slot>s.

This fixes the test from web-platform-tests/wpt#9212 in
Gecko.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19878)
<!-- Reviewable:end -->

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 30, 2018

servo: Merge #19878 - selectors: Never match ::slotted on <slot>s (fr…
…om emilio:slotted-slot); r=nox

This fixes the test from web-platform-tests/wpt#9212 in
Gecko.

Source-Repo: https://github.com/servo/servo
Source-Revision: 82922c97dc0313736fedb8021b205d4f84088a15

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ec1b0b5dcf36a50fe9b1cd5b087efb5f665cc79e

mykmelez pushed a commit to mozilla/gecko that referenced this pull request Jan 30, 2018

servo: Merge #19878 - selectors: Never match ::slotted on <slot>s (fr…
…om emilio:slotted-slot); r=nox

This fixes the test from web-platform-tests/wpt#9212 in
Gecko.

Source-Repo: https://github.com/servo/servo
Source-Revision: 82922c97dc0313736fedb8021b205d4f84088a15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.