Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add css-align/OWNERS #9215

Merged
merged 2 commits into from Mar 9, 2018

Conversation

Projects
None yet
5 participants
@foolip
Copy link
Contributor

foolip commented Jan 27, 2018

No description provided.

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Jan 27, 2018

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Jan 27, 2018

@emilio, @javifernandez, this is like #9214 except that I went looking for directories in css/ without OWNERS as well. Not a lot of activity here, but both of you showed up.

I won't land anything without an explicit yes, so if you'd rather not be listed here, please say no or nothing :)

@emilio

This comment has been minimized.

Copy link
Contributor

emilio commented Jan 27, 2018

This wfm, thanks! Maybe @MatsPalmgren or @dholbert are also interested. Most of the tests in css/vendor-imports/mozilla/mozilla-central-reftests/align3/ are theirs :)

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 27, 2018

Build ERRORED

Started: 2018-03-09 03:10:52
Finished: 2018-03-09 03:13:52

Failing Jobs

  • manifest_upload
  • lint
  • update_built
  • firefox:nightly
  • tools_unittest in py27
  • tools_unittest in py36
  • tools_unittest in pypy
  • resources_unittest in py27
  • wpt_integration in py27,py27-flake8
  • wptrunner_infrastructure
  • build_css
  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 25, 2018

@MatsPalmgren, @dholbert, should I list you?

@javifernandez, should I remove you?

@dholbert

This comment has been minimized.

Copy link
Contributor

dholbert commented Mar 1, 2018

Sure, I'm happy to be listed. (AFAIK this is my first time being listed in OWNERS in this repo, so I'm not sure what this means. :) Does it mean I might sometimes get asked to review new tests in this directory? That's fine with me.)

@foolip foolip merged commit 72c64a5 into master Mar 9, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@foolip foolip deleted the css-align-owners branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.