Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support viewport's snapping on cc. #9219

Merged
merged 1 commit into from Feb 3, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 28, 2018

To support viewport snapping on cc, before RootLayerScrolling is
enabled, we should plumb the SnapContainerData to the composited
scroll layers in PaintLayerCompositor.

This patch also makes sure that SnapAreaCalculation is correct
regardless of whether RootLayerScrolling is enabled or not.

Bug: 795404
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I836f291e1c43d54f3d2470702934d6b63e8fc964
Reviewed-on: https://chromium-review.googlesource.com/878019
Commit-Queue: Sandra Sun sunyunjia@chromium.org
Reviewed-by: David Bokan bokan@chromium.org
Reviewed-by: Majid Valipour majidvp@chromium.org
Cr-Commit-Position: refs/heads/master@{#534286}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 28, 2018

Build PASSED

Started: 2018-02-03 23:23:21
Finished: 2018-02-03 23:29:46

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-878019 branch 6 times, most recently from 3c22e66 to 4f579b9 Jan 28, 2018

Support viewport's snapping on cc.
To support viewport snapping on cc, before RootLayerScrolling is
enabled, we should plumb the SnapContainerData to the composited
scroll layers in PaintLayerCompositor.

This patch also makes sure that SnapAreaCalculation is correct
regardless of whether RootLayerScrolling is enabled or not.

Bug: 795404
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I836f291e1c43d54f3d2470702934d6b63e8fc964
Reviewed-on: https://chromium-review.googlesource.com/878019
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534286}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-878019 branch from 4f579b9 to 22c140c Feb 3, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit eae1d4b into master Feb 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-878019 branch Feb 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.