Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use document.scrollingElement for browsing-the-web/scroll-to-fragid/003.html #9228

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
4 participants
@fred-wang
Copy link
Contributor

fred-wang commented Jan 29, 2018

browsing-the-web/scroll-to-fragid/003.html uses document.body in standard mode
to handle scrolling of the viewport while the CSSOMView specification says it
should use document.documentElement. This makes the test fails in all web
engines but WebKit due to [1]. This commit replace such instances by
document.scrollingElement so that the test works in any mode or web engine.
This closes issue #6289.

[1] https://bugs.webkit.org/show_bug.cgi?id=5991

Use document.scrollingElement for browsing-the-web/scroll-to-fragid/0…
…03.html

browsing-the-web/scroll-to-fragid/003.html uses document.body in standard mode
to handle scrolling of the viewport while the CSSOMView specification says it
should use document.documentElement. This makes the test fails in all web
engines but WebKit due to [1]. This commit replace such instances by
document.scrollingElement so that the test works in any mode or web engine.
This closes issue #6289.

[1] https://bugs.webkit.org/show_bug.cgi?id=5991

@wpt-pr-bot wpt-pr-bot added the html label Jan 29, 2018

@wpt-pr-bot wpt-pr-bot requested review from jdm, jgraham and zqzhang Jan 29, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 29, 2018

Build PASSED

Started: 2018-01-29 14:12:27
Finished: 2018-01-29 14:21:28

Failing Jobs

  • safari:11.0

View more information about this build on:

@gsnedders
Copy link
Contributor

gsnedders left a comment

Actually, do we have a test anywhere that tests behaviour with document.body after this change?

@gsnedders
Copy link
Contributor

gsnedders left a comment

I don't think we do, so we need a test for the document.body case, please! We should have some test that fails in Webkit given the difference in behaviour here.

@gsnedders
Copy link
Contributor

gsnedders left a comment

Oh, actually we have tests for that in css/cssom-view/scrollingElement.html

@gsnedders gsnedders merged commit fc33ef7 into master Jan 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the issue-6289 branch Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.