Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test document.body and document.bgColor when root is not <html> #9231

Merged
merged 4 commits into from Feb 12, 2018

Conversation

Projects
None yet
5 participants
@zcorpan
Copy link
Contributor

zcorpan commented Jan 29, 2018

@zcorpan zcorpan requested review from bzbarsky and annevk Jan 29, 2018

@wpt-pr-bot wpt-pr-bot added the html label Jan 29, 2018

@wpt-pr-bot wpt-pr-bot requested review from ayg, jdm, jgraham and zqzhang Jan 29, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 29, 2018

Build PASSED

Started: 2018-02-05 13:55:42
Finished: 2018-02-05 14:06:56

View more information about this build on:

@annevk

annevk approved these changes Jan 29, 2018

Copy link
Member

annevk left a comment

It might also be worth testing with a document inside an <iframe>. Sometimes a browsing context ends up mattering somehow (and it probably shouldn't here).

@bzbarsky
Copy link
Contributor

bzbarsky left a comment

This is generally good, but we should also have a test for the "frameset in html" case, where .fgColor is not propagated to the frameset, even though document.body is the frameset.

@zcorpan zcorpan force-pushed the zcorpan/whatwg-html-3403 branch from 825c80b to e8c34c5 Feb 5, 2018

@zcorpan

This comment has been minimized.

Copy link
Contributor Author

zcorpan commented Feb 5, 2018

I've address comments and rebased to resolve conflict with 08cb168 (which wasn't much of a conflict, just us adding new tests in the same place).

zcorpan added a commit to whatwg/html that referenced this pull request Feb 5, 2018

@annevk

annevk approved these changes Feb 5, 2018

@zcorpan zcorpan merged commit 7996359 into master Feb 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zcorpan zcorpan deleted the zcorpan/whatwg-html-3403 branch Feb 12, 2018

zcorpan added a commit to whatwg/html that referenced this pull request Feb 12, 2018

alice added a commit to alice/html that referenced this pull request Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.