Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Add WPT tests for feature policy" #9238

Merged
merged 1 commit into from Feb 25, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 29, 2018

This is a reland of 6252427ab5415839618a0d25e4f6e61becce3923.

Original change's description:

Add WPT tests for feature policy

  1. Added tests for header policy.
    a. document.policy shows correctly parsed policy
    b. local / remote iframes without allow attribute correctly inherit
    document.policy
    c. dynamically update allow attribute updates the policy correctly.

  2. Added tests for nested policies.

Bug: 732003
Change-Id: I869449f6bba89fc58997355df27249f403d76808
Reviewed-on: https://chromium-review.googlesource.com/796952
Commit-Queue: Luna Lu loonybear@chromium.org
Reviewed-by: Ian Clelland iclelland@chromium.org
Cr-Commit-Position: refs/heads/master@{#531698}

Bug: 732003
Change-Id: I46065efff8c5af2d5279721f3c759580b0807e05
Reviewed-on: https://chromium-review.googlesource.com/887324
Reviewed-by: Ian Clelland iclelland@chromium.org
Commit-Queue: Luna Lu loonybear@chromium.org
Cr-Commit-Position: refs/heads/master@{#538904}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 29, 2018

Build ERRORED

Started: 2018-02-24 06:01:15
Finished: 2018-02-24 06:56:39

Failing Jobs

  • firefox:nightly
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-887324 branch 2 times, most recently from 507444a to 7721f3e Jan 31, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-887324 branch 3 times, most recently from 199a00d to b4c6956 Feb 22, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-887324 branch from b4c6956 to 66bd0a3 Feb 23, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 24, 2018

The Firefox Travis job timed out here, the log ends with "The job exceeded the maximum time limit for jobs, and has been terminated".

It's oddly similar to the way that #9641 failed, right after some certutil stuff.

Restarting that job once to see if it goes away.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 24, 2018

Note that the Chrome job took 45 minutes, so it's possible there are just too many tests timing out here to run them 10 times within the 50 minute deadline.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 24, 2018

Somehow unable to restart, so I'll rebase instead to get the same effect.

Reland "Add WPT tests for feature policy"
This is a reland of 6252427ab5415839618a0d25e4f6e61becce3923.

Original change's description:
> Add WPT tests for feature policy
>
> 1. Added tests for header policy.
>     a. document.policy shows correctly parsed policy
>     b. local / remote iframes without allow attribute correctly inherit
>        document.policy
>     c. dynamically update allow attribute updates the policy correctly.
>
> 2. Added tests for nested policies.
>
> Bug: 732003
> Change-Id: I869449f6bba89fc58997355df27249f403d76808
> Reviewed-on: https://chromium-review.googlesource.com/796952
> Commit-Queue: Luna Lu <loonybear@chromium.org>
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531698}

Bug: 732003
Change-Id: I46065efff8c5af2d5279721f3c759580b0807e05
Reviewed-on: https://chromium-review.googlesource.com/887324
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538904}

@foolip foolip force-pushed the chromium-export-cl-887324 branch from 66bd0a3 to 42f037e Feb 24, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 25, 2018

OK, based on https://pulls.web-platform-tests.org/build/24839 and in particular https://pulls.web-platform-tests.org/job/24839.11 and the fact that the Chrome job took 46 minutes, I'm fairly confident this was a timeout problem, i.e. #7660.

I will force merge this.

@foolip foolip merged commit e494987 into master Feb 25, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@foolip foolip deleted the chromium-export-cl-887324 branch Feb 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.