Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'x' as a unit of resolution #9245

Merged
merged 1 commit into from May 12, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 30, 2018

In https://drafts.csswg.org/css-values-4/#resolution, 'x' is defined as
a synonym for dppx. Add support for parsing 'x' as dots per px.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/FsD97U77tss

Bug: 630597, 807653
Change-Id: I70c440c89e42cd005a9c58fd89745a5603e0dee6
Reviewed-on: https://chromium-review.googlesource.com/892467
Commit-Queue: Chris Nardi cnardi@chromium.org
Reviewed-by: Emil A Eklund eae@chromium.org
Cr-Commit-Position: refs/heads/master@{#558119}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 30, 2018

Build PASSED

Started: 2018-01-30 15:41:49
Finished: 2018-01-30 15:45:45

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-892467 branch from 667306a to 38fd289 Jan 30, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-892467 branch from 38fd289 to 86ad35b May 12, 2018

@wpt-pr-bot wpt-pr-bot added the html label May 12, 2018

Add support for 'x' as a unit of resolution
In https://drafts.csswg.org/css-values-4/#resolution, 'x' is defined as
a synonym for dppx. Add support for parsing 'x' as dots per px.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/FsD97U77tss

Bug: 630597, 807653
Change-Id: I70c440c89e42cd005a9c58fd89745a5603e0dee6
Reviewed-on: https://chromium-review.googlesource.com/892467
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558119}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-892467 branch from 86ad35b to ee98a04 May 12, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 2e894de into master May 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-892467 branch May 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.