Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-elements: document.createElementNS() should check namespace URIs. #9246

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 30, 2018

Custom Element V1 supports only XHTML namespace, and
Document::createElemenNS() ignored specified namespace URI.

  • Reject namespace URIs other than XHTML's one on finding 'definition'.
  • Check existence of 'definition' instead of names on choosing
    appropriate element factory.

The new behavior matches to Firefox and the specification.

Bug: 806665
Change-Id: I458685eeb48019be9da086b3b2a8703deac655c6
Reviewed-on: https://chromium-review.googlesource.com/892541
Reviewed-by: Yoshifumi Inoue yosin@chromium.org
Commit-Queue: Kent Tamura tkent@chromium.org
Cr-Commit-Position: refs/heads/master@{#532782}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 30, 2018

Build PASSED

Started: 2018-01-30 06:40:41
Finished: 2018-01-30 06:52:33

View more information about this build on:

custom-elements: document.createElementNS() should check namespace URIs.
Custom Element V1 supports only XHTML namespace, and
Document::createElemenNS() ignored specified namespace URI.
 - Reject namespace URIs other than XHTML's one on finding 'definition'.
 - Check existence of 'definition' instead of names on choosing
   appropriate element factory.

The new behavior matches to Firefox and the specification.

Bug: 806665
Change-Id: I458685eeb48019be9da086b3b2a8703deac655c6
Reviewed-on: https://chromium-review.googlesource.com/892541
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532782}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-892541 branch from 0161e14 to a0a4891 Jan 30, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f600b8a into master Jan 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-892541 branch Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.