Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-elements: document.createElementNS() should set prefixes to custom elements. #9250

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

commented Jan 30, 2018

We had a bug that createElementNS() ignored prefixes.
New behavior matches to the specification and Firefox.

  • Document-createElementNS.html:
    Fix a copypasta error.

  • ScriptCustomElementDefinition::CreateElementSync:
    Implement Step 6.1.10.

  • Document::createElementNS:
    Fix an argument of definition lookup.

  • CustomElement::CreateUndefinedElement:
    Use Document::CreateRawElement(), which sets prefixes correctly,
    instead of HTMLElementFactory::createHTMLElement().

  • ustomElementDefinition::CreateElementAsync:
    Use Document::CreateRawElement(), which sets prefixes correctly,
    instead of HTMLElementFactory::createRawHTMLElement().

Bug: 806639
Change-Id: I74b431d4475d7cf84f65ab0ff1b24773cbc64079
Reviewed-on: https://chromium-review.googlesource.com/892802
Reviewed-by: Yoshifumi Inoue yosin@chromium.org
Commit-Queue: Kent Tamura tkent@chromium.org
Cr-Commit-Position: refs/heads/master@{#532821}

@wpt-pr-bot
Copy link
Collaborator

left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

commented Jan 30, 2018

Build PASSED

Started: 2018-01-30 10:16:42
Finished: 2018-01-30 10:22:01

View more information about this build on:

custom-elements: document.createElementNS() should set prefixes to cu…
…stom elements.

We had a bug that createElementNS() ignored prefixes.
New behavior matches to the specification and Firefox.

* Document-createElementNS.html:
  Fix a copypasta error.

* ScriptCustomElementDefinition::CreateElementSync:
  Implement Step 6.1.10.

* Document::createElementNS:
  Fix an argument of definition lookup.

* CustomElement::CreateUndefinedElement:
  Use Document::CreateRawElement(), which sets prefixes correctly,
  instead of HTMLElementFactory::createHTMLElement().

* ustomElementDefinition::CreateElementAsync:
  Use Document::CreateRawElement(), which sets prefixes correctly,
  instead of HTMLElementFactory::createRawHTMLElement().

Bug: 806639
Change-Id: I74b431d4475d7cf84f65ab0ff1b24773cbc64079
Reviewed-on: https://chromium-review.googlesource.com/892802
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532821}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-892802 branch from f7b6477 to 087d248 Jan 30, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit b22a445 into master Jan 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-892802 branch Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.