Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FetchEvent.clientId non-nullable #9253

Merged
merged 1 commit into from Feb 1, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 30, 2018

The current spec says that it isn't nullable [1]. This CL also removes
null check in client-navigate-worker.js. There is test coverage for null
clientId in fetch-event.https.html so the explicit check here is not
needed.

You can find spec discussion in [2].

[1]
w3c/ServiceWorker@8b483b0
[2] w3c/ServiceWorker#1266

Bug: 807818
Change-Id: I5ae4f866651931fee732516377b0fa155b0b5e22
Reviewed-on: https://chromium-review.googlesource.com/892762
Commit-Queue: Kenichi Ishibashi bashi@chromium.org
Reviewed-by: Matt Falkenhagen falken@chromium.org
Reviewed-by: Kinuko Yasuda kinuko@chromium.org
Cr-Commit-Position: refs/heads/master@{#533567}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 30, 2018

Build PASSED

Started: 2018-02-01 06:27:44
Finished: 2018-02-01 06:34:36

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-892762 branch 3 times, most recently from 9a193e7 to edbbc3b Feb 1, 2018

Make FetchEvent.clientId non-nullable
The current spec says that it isn't nullable [1]. This CL also removes
null check in client-navigate-worker.js. There is test coverage for null
clientId in fetch-event.https.html so the explicit check here is not
needed.

You can find spec discussion in [2].

[1]
w3c/ServiceWorker@8b483b0
[2] w3c/ServiceWorker#1266

Bug: 807818
Change-Id: I5ae4f866651931fee732516377b0fa155b0b5e22
Reviewed-on: https://chromium-review.googlesource.com/892762
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533567}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-892762 branch from edbbc3b to 895ac22 Feb 1, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit cd86de5 into master Feb 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-892762 branch Feb 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.