Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdriver: make cookie tests spec compliant #9259

Merged
merged 2 commits into from Jan 30, 2018

Conversation

Projects
None yet
4 participants
@carlosgcampos
Copy link
Contributor

carlosgcampos commented Jan 30, 2018

  • Add and remove commands return sucess with data null.
  • Expiry is optional for session cookies and my be omitted.

carlosgcampos added some commits Jan 30, 2018

webdriver: commands to add and remove cookies return null
Tests are expecting that those commands return a dictionary, I guess the
added/removed cookie. The spec says that the command should return
success with data null in both cases.
webdriver: expiry is optional in session cookies
Tests are expecting it to be always null for session cookies, but the
spec says that optional fields may be omitted.
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 30, 2018

Build PASSED

Started: 2018-01-30 16:13:06
Finished: 2018-01-30 16:22:12

Failing Jobs

  • chrome:dev

View more information about this build on:

@andreastt andreastt merged commit 1702e9c into web-platform-tests:master Jan 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@carlosgcampos carlosgcampos deleted the WebKitGTK:wd-cookies branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.