Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service worker: Deflake fetch-event.https.html. #9260

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 30, 2018

The test was using add_result_callback() which is triggered after a test
finishes. Unfortunately this file uses both async_test and promise_test.
promise_tests run sequentially but async_tests run in parallel. Therefore,
the add_result_callback was being called every time an async_test finished,
causing a race when this promise_test was in the middle of execution.

R=shimazu

Bug: 807014
Change-Id: Ic1bc568fe812f540feec901f95cc89684ef1cae2
Reviewed-on: https://chromium-review.googlesource.com/892553
Reviewed-by: Makoto Shimazu shimazu@chromium.org
Commit-Queue: Matt Falkenhagen falken@chromium.org
Cr-Commit-Position: refs/heads/master@{#532758}

service worker: Deflake fetch-event.https.html.
The test was using add_result_callback() which is triggered after a test
finishes. Unfortunately this file uses both async_test and promise_test.
promise_tests run sequentially but async_tests run in parallel. Therefore,
the add_result_callback was being called every time an async_test finished,
causing a race when this promise_test was in the middle of execution.

R=shimazu

Bug: 807014
Change-Id: Ic1bc568fe812f540feec901f95cc89684ef1cae2
Reviewed-on: https://chromium-review.googlesource.com/892553
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532758}
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 30, 2018

Build PASSED

Started: 2018-01-30 18:03:16
Finished: 2018-01-30 18:12:54

Failing Jobs

  • chrome:dev

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 318f833 into master Jan 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-b72e89031f branch Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.