Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disabled attribute from Element Clear test. #9263

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
3 participants
@jgraham
Copy link
Contributor

jgraham commented Jan 30, 2018

is not a mutable form control element and it should not be possible to call the WebDriver:ElementClear command on it. We test this in test_select as part of element_clear.py in WPT, but the test uses a element which triggers the
wrong code path in Marionette.

MozReview-Commit-ID: 4ybEdLY6OEo

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1432804 [ci skip]


This change is Reviewable

Remove disabled attribute from Element Clear test.
<select> is not a mutable form control element and it should not
be possible to call the WebDriver:ElementClear command on it.
We test this in test_select as part of element_clear.py in WPT,
but the test uses a <select disabled> element which triggers the
wrong code path in Marionette.

MozReview-Commit-ID: 4ybEdLY6OEo

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1432804 [ci skip]
@jgraham

This comment has been minimized.

Copy link
Contributor Author

jgraham commented Jan 30, 2018

Code reviewed upstream.

@jgraham jgraham merged commit ec43d78 into master Jan 30, 2018

@jgraham jgraham deleted the sync_633f5861883dce925f4870d4d49068545fd6a8a7 branch Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.