Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at the snapshots when invalidating due to stylesheet changes. #9280

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
3 participants
@jgraham
Copy link
Contributor

jgraham commented Jan 30, 2018

The selectorText test happens to pass right now because well, we don't implement
the setter yet1, but would fail if we implemented an specific invalidation in
the way I'd have done it yesterday.

MozReview-Commit-ID: DrMTgLzQcnk

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1432850 [ci skip]


This change is Reviewable

Look at the snapshots when invalidating due to stylesheet changes.
The selectorText test happens to pass right now because well, we don't implement
the setter yet[1], but would fail if we implemented an specific invalidation in
the way I'd have done it yesterday.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=37468

MozReview-Commit-ID: DrMTgLzQcnk

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1432850 [ci skip]
@jgraham

This comment has been minimized.

Copy link
Contributor Author

jgraham commented Jan 30, 2018

Code reviewed upstream.

@jgraham jgraham merged commit a56b219 into master Jan 30, 2018

@jgraham jgraham deleted the sync_56764b8e6671e67e4f591126625694bb268f6ea3 branch Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.