Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the .body setter with the spec a bit better. #9282

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
3 participants
@jgraham
Copy link
Contributor

jgraham commented Jan 30, 2018

There are two changes here:

  1. We allow setting .body even if the root element is not an html:html. This
    is what the spec says to do, and what we used to do before the changes in bug
  1. No tests for this yet, pending
    whatwg/html#3403 getting resolved.
  1. We use GetBody(), not GetBodyElement(), to look for an existing thing to
    replace. This matters if there are s involved.

MozReview-Commit-ID: JCaQGHKgzE7

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1276438 [ci skip]


This change is Reviewable

Align the .body setter with the spec a bit better.
There are two changes here:

1) We allow setting .body even if the root element is not an <html:html>.  This
is what the spec says to do, and what we used to do before the changes in bug
366200.  No tests for this yet, pending
whatwg/html#3403 getting resolved.

2) We use GetBody(), not GetBodyElement(), to look for an existing thing to
replace.  This matters if there are <frameset>s involved.

MozReview-Commit-ID: JCaQGHKgzE7

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1276438 [ci skip]
@jgraham

This comment has been minimized.

Copy link
Contributor Author

jgraham commented Jan 30, 2018

Code reviewed upstream.

@jgraham jgraham merged commit 5f3ccbe into master Jan 30, 2018

@jgraham jgraham deleted the sync_08cb16810a35273e5f400acd1fbdc352559addfe branch Jan 30, 2018

@wpt-pr-bot wpt-pr-bot added the html label Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.