Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawImage with zero size canvas as the source image should throw #9286

Merged
merged 1 commit into from Feb 7, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 30, 2018

This change list corrects the behavior of 2D context drawImage to throw
an InvalidStateError exception when the source image is a canvas with
size zero.
It also matches the behavior for OffscreenCanvas and adds respective
wpt tests.

Associated spec change: whatwg/html#3398

Bug: 805677
Change-Id: Id938af6683f5fc4e94e97327e4d729838f4bfb00
Reviewed-on: https://chromium-review.googlesource.com/893423
Commit-Queue: Mohammad Reza Zakerinasab zakerinasab@chromium.org
Reviewed-by: Justin Novosad junov@chromium.org
Cr-Commit-Position: refs/heads/master@{#535123}


This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 30, 2018

Build PASSED

Started: 2018-02-07 20:32:23
Finished: 2018-02-07 20:37:50

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-893423 branch 3 times, most recently from 9526c75 to 76330b0 Jan 31, 2018

drawImage with zero size canvas as the source image should throw
This change list corrects the behavior of 2D context drawImage to throw
an InvalidStateError exception when the source image is a canvas with
size zero.
It also matches the behavior for OffscreenCanvas and adds respective
wpt tests.

Associated spec change: whatwg/html#3398

Bug: 805677
Change-Id: Id938af6683f5fc4e94e97327e4d729838f4bfb00
Reviewed-on: https://chromium-review.googlesource.com/893423
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535123}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-893423 branch from 76330b0 to d1a1b20 Feb 7, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 04c852b into master Feb 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-893423 branch Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.