Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Fix CSSVariableReferenceValue validation. #9293

Merged
merged 1 commit into from Jan 31, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 31, 2018

We change CSSVariableReferenceValue to reject invalid custom property
names as per spec. We also remove .tentative extension from related
tests.

We also remove some unit tests that are replaced by WPTs.

Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssvariablereferencevalue

Bug: 545318
Change-Id: I95cfe1c167a60c94083a1474b384fd584d05cca9
Reviewed-on: https://chromium-review.googlesource.com/895124
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#533228}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 31, 2018

Build PASSED

Started: 2018-01-31 08:14:16
Finished: 2018-01-31 08:19:20

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-895124 branch 3 times, most recently from 2e9805f to 2f4743a Jan 31, 2018

[css-typed-om] Fix CSSVariableReferenceValue validation.
We change CSSVariableReferenceValue to reject invalid custom property
names as per spec. We also remove .tentative extension from related
tests.

We also remove some unit tests that are replaced by WPTs.

Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssvariablereferencevalue

Bug: 545318
Change-Id: I95cfe1c167a60c94083a1474b384fd584d05cca9
Reviewed-on: https://chromium-review.googlesource.com/895124
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533228}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-895124 branch from 2f4743a to f99182e Jan 31, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit d17d539 into master Jan 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-895124 branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.