Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip out-of-flow boxes merging anonymous flex items. #9298

Merged
merged 1 commit into from Jan 31, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 31, 2018

A misread of the spec made us skip out-of-flow boxes merging anonymous
flex items. Only merge anonymous flex items which are truly box
siblings.

Adjusted the wpt tests accordingly. Fwiw, Firefox nightly now passes
all of wpt/css/css-flexbox/anonymous-*

Bug: 788379, 806151
Change-Id: I124740e5d2150becdcc03ded26773a69607e0bbb
Reviewed-on: https://chromium-review.googlesource.com/895283
Reviewed-by: Christian Biesinger cbiesinger@chromium.org
Commit-Queue: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/heads/master@{#533440}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 31, 2018

Build PASSED

Started: 2018-01-31 22:30:14
Finished: 2018-01-31 22:33:56

View more information about this build on:

Do not skip out-of-flow boxes merging anonymous flex items.
A misread of the spec made us skip out-of-flow boxes merging anonymous
flex items. Only merge anonymous flex items which are truly box
siblings.

Adjusted the wpt tests accordingly. Fwiw, Firefox nightly now passes
all of wpt/css/css-flexbox/anonymous-*

Bug: 788379, 806151
Change-Id: I124740e5d2150becdcc03ded26773a69607e0bbb
Reviewed-on: https://chromium-review.googlesource.com/895283
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533440}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-895283 branch from 100d6dd to be2181d Jan 31, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit fcc7ece into master Jan 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-895283 branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.