Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update move-to-fullscreen-iframe-manual.html to match the spec #9299

Merged
merged 2 commits into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@foolip
Copy link
Contributor

foolip commented Jan 31, 2018

This test is from https://chromium-review.googlesource.com/776599 and
the explanation seemed to make sense spec-wise. But when matching the
spec more closely this begins to fail, and it seems that per spec
this updated behavior is what would happen.

Update move-to-fullscreen-iframe-manual.html to match the spec
This test is from https://chromium-review.googlesource.com/776599 and
the explanation seemed to make sense spec-wise. But when matching the
spec more closely this begins to fail, and it seems that per spec
this updated behavior is what would happen.

@wpt-pr-bot wpt-pr-bot requested review from aliams, jernoble and upsuper Jan 31, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 31, 2018

Build PASSED

Started: 2018-02-23 10:57:02
Finished: 2018-02-23 11:08:07

Failing Jobs

  • chrome:dev

View more information about this build on:

@upsuper

upsuper approved these changes Feb 1, 2018

Copy link
Member

upsuper left a comment

It's definitely a weird case... but the explanation makes sense, I guess...

@@ -22,10 +22,13 @@
document.onfullscreenchange = t.step_func_done(() => {
assert_equals(document.fullscreenElement, null, "document's fullscreen element");

This comment has been minimized.

Copy link
@upsuper

upsuper Feb 1, 2018

Member

Probably consider adding assertions in the first level of event handler to clarify that both documents have fullscreen element at that point.

This comment has been minimized.

Copy link
@foolip

foolip Feb 23, 2018

Author Contributor

Done!

@foolip foolip merged commit db1a703 into master Feb 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@foolip foolip deleted the oops-move-to-fullscreen-iframe branch Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.