Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create permissions test suite with IDL tests #9301

Merged
merged 3 commits into from Jun 7, 2018

Conversation

Projects
None yet
6 participants
@Honry
Copy link
Contributor

Honry commented Jan 31, 2018

No description provided.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 31, 2018

Build PASSED

Started: 2018-01-31 07:44:04
Finished: 2018-01-31 07:51:59

View more information about this build on:

@Honry

This comment has been minimized.

Copy link
Contributor Author

Honry commented Jan 31, 2018

@jyasskin, @mounirlamouri, @marcoscaceres, I added you in the OWNERS file to help review Permissions API tests as you are spec editors, which means you'll get pinged on new PRs. Please let me know if you want to be removed.

@mounirlamouri

This comment has been minimized.

Copy link
Contributor

mounirlamouri commented Jan 31, 2018

sgtm. @Honry did you look at the Blink tests? I wonder if there are some that could be moved to WPT.

@Honry

This comment has been minimized.

Copy link
Contributor Author

Honry commented Jan 31, 2018

sgtm. @Honry did you look at the Blink tests? I wonder if there are some that could be moved to WPT.

Yeah, they are located at here, and I would like to move them to WPT.

@Honry

This comment has been minimized.

Copy link
Contributor Author

Honry commented Feb 1, 2018

@mounirlamouri, most of Blink tests require user interaction to invoke/revoke permissions, which is under implementing at #5671, so I will go back to it once the new WebDriver feature is online.

@domenic domenic removed their request for review Apr 20, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor

lukebjerring commented Jun 6, 2018

What's happening with this PR?

@marcoscaceres

This comment has been minimized.

Copy link
Contributor

marcoscaceres commented Jun 7, 2018

I guess these could land to start testing the IDL? @Honry, is the IDL still up to date?

@Honry

This comment has been minimized.

Copy link
Contributor Author

Honry commented Jun 7, 2018

@Honry, is the IDL still up to date?

@marcoscaceres, no, I will do it soon.

@Honry

This comment has been minimized.

Copy link
Contributor Author

Honry commented Jun 7, 2018

@lukebjerring, @marcoscaceres, PTAL, I've appended the header to idl file, so that next update is a no-op.

PermissionStatus: ['permissionStatus']
});
idl_array.test();
done();

This comment has been minimized.

Copy link
@marcoscaceres

marcoscaceres Jun 7, 2018

Contributor

done() should be outside the test.

@marcoscaceres
Copy link
Contributor

marcoscaceres left a comment

apart from done(), looks great @Honry!

@Honry

This comment has been minimized.

Copy link
Contributor Author

Honry commented Jun 7, 2018

@marcoscaceres, thanks for your review! done() is removed.

@marcoscaceres
Copy link
Contributor

marcoscaceres left a comment

👌

@marcoscaceres marcoscaceres merged commit 5133c54 into web-platform-tests:master Jun 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Honry Honry deleted the Honry:permissions-idl branch Jun 7, 2018

dhdavvie pushed a commit to dhdavvie/wpt that referenced this pull request Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.