Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional test for readAsBinaryString #9302

Merged

Conversation

Projects
None yet
4 participants
@kaixinjxq
Copy link
Contributor

kaixinjxq commented Jan 31, 2018

Fix issue #3374.

@Ms2ger, PTAL.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 31, 2018

Build PASSED

Started: 2018-02-01 05:24:54
Finished: 2018-02-01 05:36:13

View more information about this build on:

@annevk

annevk approved these changes Jan 31, 2018

const blob = new Blob(["σ"]);
const reader = new FileReader();
reader.onload = t.step_func(() => {

This comment has been minimized.

Copy link
@annevk

annevk Jan 31, 2018

Member

Nit: you can use step_func_done() to avoid having to invoke done().

This comment has been minimized.

Copy link
@kaixinjxq

kaixinjxq Feb 1, 2018

Author Contributor

Thanks @annevk, update the nit issue, PTAL.

@annevk annevk merged commit 225d3a9 into web-platform-tests:master Feb 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@annevk

This comment has been minimized.

Copy link
Member

annevk commented Feb 1, 2018

Thanks @kaixinjxq!

@kaixinjxq kaixinjxq deleted the kaixinjxq:FileAPI_readAsBinaryString branch Feb 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.