Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagebitmap redirect to same origin #9314

Merged
merged 1 commit into from Mar 2, 2018

Conversation

Projects
None yet
4 participants
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 31, 2018

The first commit is #9313; the second may be controversial, but I'm not in a hurry to land it.

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Jan 31, 2018

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 31, 2018

Build PASSED

Started: 2018-02-08 16:30:40
Finished: 2018-02-08 16:35:15

Failing Jobs

  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/2dcontext/imagebitmap/createImageBitmap-origin.sub.html   TIMEOUT: 1
ERROR: 9
  cross-origin HTMLImageElement FAIL: 9
Can't find variable: createImageBitmap
  cross-origin HTMLVideoElement FAIL: 9
Can't find variable: createImageBitmap
  cross-origin SVGImageElement FAIL: 9
Can't find variable: createImageBitmap
  redirected to cross-origin HTMLVideoElement FAIL: 9
Can't find variable: createImageBitmap
  redirected to same-origin HTMLVideoElement FAIL: 9
Can't find variable: createImageBitmap
  unclean HTMLCanvasElement FAIL: 9
Can't find variable: createImageBitmap
  unclean ImageBitmap FAIL: 9
Can't find variable: createImageBitmap
@annevk
Copy link
Member

annevk left a comment

Also seems this needs to be rebased on top of the PR I just approved?

};
video.onerror = reject;
video.src = toDataUrl(type, data);
console.log(video.src)

This comment has been minimized.

Copy link
@annevk

annevk Feb 1, 2018

Member

Need to remove this line.

Add a test for a cross-origin redirect to a same-origin video.
It's not clear to me if the expected result here is well-defined. Chrome and
my in-progress WebKit implementation pass; Gecko fails.

@Ms2ger Ms2ger force-pushed the imagebitmap-redirect-to-same-origin branch from a5402fd to c2583ef Feb 8, 2018

@annevk

annevk approved these changes Mar 2, 2018

@annevk annevk merged commit 18ea986 into master Mar 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@annevk

This comment has been minimized.

Copy link
Member

annevk commented Mar 2, 2018

I've landed this as-is for now. I think not throwing for a cross-origin to same-origin redirect might actually be okay, given how we deal with <iframe> (it's same-origin there too), but it's indeed not defined well at the moment and it's best to have a test of sorts in.

@annevk annevk deleted the imagebitmap-redirect-to-same-origin branch Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.