Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat test for -webkit-appearance #9315

Merged

Conversation

Projects
None yet
5 participants
@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Jan 31, 2018

This is an not-yet-spec'd feature, but is currently supported by Chrome,
Opera, Safari, and Edge, and Firefox has indicated that they plan to
support it (https://bugzilla.mozilla.org/show_bug.cgi?id=1368555).

Add compat test for -webkit-appearance
This is an non-spec feature, but is currently supported by Chrome,
Opera, Safari, and Edge, and Firefox has indicated that they plan to
support it (https://bugzilla.mozilla.org/show_bug.cgi?id=1368555).

@wpt-pr-bot wpt-pr-bot added the compat label Jan 31, 2018

@wpt-pr-bot wpt-pr-bot requested review from cdumez, foolip and miketaylr Jan 31, 2018

@stephenmcgruer

This comment has been minimized.

Copy link
Contributor Author

stephenmcgruer commented Jan 31, 2018

See webcompat/web-bugs#7309 for the GWS webcompat issue relating to this.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 31, 2018

Build PASSED

Started: 2018-01-31 16:42:33
Finished: 2018-01-31 16:49:30

View more information about this build on:

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 1, 2018

I'm gonna disappear mostly next week, so looking for other volunteer reviewers :)

@stephenmcgruer

This comment has been minimized.

Copy link
Contributor Author

stephenmcgruer commented Feb 7, 2018

Ping @miketaylr @cdumez - can either of you review?

@miketaylr

This comment has been minimized.

Copy link
Contributor

miketaylr commented Feb 7, 2018

Mechanically, LGTM -- but I want to double-check the values with what we want to implement in Gecko. Will report back.

@miketaylr
Copy link
Contributor

miketaylr left a comment

Looking at https://bugzilla.mozilla.org/show_bug.cgi?id=1368555, looks like we intend on supporting everything that Chrome does.

Once we actually implement and ship, let's spec it and update tests if it turns out that this list isn't complete.

@miketaylr miketaylr merged commit 1419513 into web-platform-tests:master Feb 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.