Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Implement CSSMathValue serialization. #9326

Merged
merged 1 commit into from Feb 1, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 1, 2018

This patch implements the new CSSMathValue serialization algorithm [1].
As explained in the bug, this serialization is impossible to do by
converting to CSSValues and then serializing them, so we have to
implement this from scratch.

We tried to make the code follow the spec algorithm as closely as
possible for easier understanding/verification.

[1] https://drafts.css-houdini.org/css-typed-om-1/#calc-serialization

Bug: 803688
Change-Id: I48987d2b76b0bac55389a014588f3fe40aecf10a
Reviewed-on: https://chromium-review.googlesource.com/896422
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#533530}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 1, 2018

Build PASSED

Started: 2018-02-01 04:23:51
Finished: 2018-02-01 04:30:07

View more information about this build on:

[css-typed-om] Implement CSSMathValue serialization.
This patch implements the new CSSMathValue serialization algorithm [1].
As explained in the bug, this serialization is impossible to do by
converting to CSSValues and then serializing them, so we have to
implement this from scratch.

We tried to make the code follow the spec algorithm as closely as
possible for easier understanding/verification.

[1] https://drafts.css-houdini.org/css-typed-om-1/#calc-serialization

Bug: 803688
Change-Id: I48987d2b76b0bac55389a014588f3fe40aecf10a
Reviewed-on: https://chromium-review.googlesource.com/896422
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533530}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-896422 branch from 7691c13 to 45a74e7 Feb 1, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 3147789 into master Feb 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-896422 branch Feb 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.