Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave out the default value when serializing font-feature-settings #9328

Merged
merged 1 commit into from Feb 1, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 1, 2018

According to the shortest-serialization principle 1, values should be
omitted if their omission wouldn't change the value of reparsing. As
"1"/"on" is the default value for font-feature-settings, omit this when
serializing, matching the behavior of Firefox.

Bug: 807744
Change-Id: Ieb8b86aa66aa303a82a895c42373177cf7f13d07
Reviewed-on: https://chromium-review.googlesource.com/896203
Reviewed-by: Darren Shen shend@chromium.org
Commit-Queue: Chris Nardi cnardi@chromium.org
Cr-Commit-Position: refs/heads/master@{#533566}


This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 1, 2018

Build PASSED

Started: 2018-02-01 06:21:16
Finished: 2018-02-01 06:27:10

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-896203 branch from 1b31d2a to e479f4d Feb 1, 2018

Leave out the default value when serializing font-feature-settings
According to the shortest-serialization principle [1], values should be
omitted if their omission wouldn't change the value of reparsing. As
"1"/"on" is the default value for font-feature-settings, omit this when
serializing, matching the behavior of Firefox.

[1]: w3c/csswg-drafts#1564

Bug: 807744
Change-Id: Ieb8b86aa66aa303a82a895c42373177cf7f13d07
Reviewed-on: https://chromium-review.googlesource.com/896203
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533566}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-896203 branch from e479f4d to 24e7b04 Feb 1, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 397e666 into master Feb 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-896203 branch Feb 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.