Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Edge 16 in Travis builds #9338

Merged
merged 1 commit into from Feb 1, 2018

Conversation

@foolip
Copy link
Contributor

foolip commented Feb 1, 2018

This change is Reviewable

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 1, 2018

Build PASSED

Started: 2018-02-01 14:43:49
Finished: 2018-02-01 14:50:40

View more information about this build on:

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 1, 2018

I've filed web-platform-tests/pulls.web-platform-tests.org#58 about the weird thing that seems to be going on with the @w3c-bots comment.

I was hoping that https://pulls.web-platform-tests.org/job/23710.13 (the Edge link) would have shown that this works by listing the tests that ran successfully, but it doesn't work due to web-platform-tests/pulls.web-platform-tests.org#47.

Anyway, expanding https://travis-ci.org/w3c/web-platform-tests/jobs/336008126#L662 shows that this has worked, and the test results show nothing surprising, some things passing some things failing, the same as before.

Assigning to @mattl and @jugglinmike to review and merge.

@Ms2ger
Copy link
Contributor

Ms2ger left a comment

LGTM, but revert the REVERTME commit.

@foolip foolip force-pushed the edge-16-travis branch from 6ea343e to 9b169e2 Feb 1, 2018

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 1, 2018

I have dropped the REVERTME commit.

@Ms2ger

Ms2ger approved these changes Feb 1, 2018

@jugglinmike
Copy link
Contributor

jugglinmike left a comment

Progress!

@jugglinmike jugglinmike merged commit bb1a4a2 into master Feb 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@foolip foolip deleted the edge-16-travis branch Feb 1, 2018

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 1, 2018

As an aside, this means it's also possible to run Edge 16 for wpt.fyi without any own hardware. Nice to have that choice I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.