Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: WPT for basic-shape <position> parsing #9343

Merged
merged 1 commit into from Feb 1, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 1, 2018

Test that basic shapes support the grammar
https://drafts.csswg.org/css-shapes/#typedef-basic-shape
https://drafts.csswg.org/css-values-4/#typedef-position

and not the additional forms allowed by the grammar
https://drafts.csswg.org/css-backgrounds-3/#propdef-background-position

Blink has deprecated support in basic shapes
(and other contexts other than background-position), so the expected
failures are while we wait for removal in M68.

BUG=804187

Change-Id: Ifcaa72f42f2b63730ec761bf4fff4d4557f82b75
Reviewed-on: https://chromium-review.googlesource.com/897071
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Eric Willigers ericwilligers@chromium.org
Cr-Commit-Position: refs/heads/master@{#533849}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 1, 2018

Build PASSED

Started: 2018-02-01 23:41:50
Finished: 2018-02-01 23:46:12

Failing Jobs

  • build_css

View more information about this build on:

CSS: WPT for basic-shape <position> parsing
Test that basic shapes support the <position> grammar
https://drafts.csswg.org/css-shapes/#typedef-basic-shape
https://drafts.csswg.org/css-values-4/#typedef-position

and not the additional forms allowed by the <bg-position> grammar
https://drafts.csswg.org/css-backgrounds-3/#propdef-background-position

Blink has deprecated <bg-position> support in basic shapes
(and other contexts other than background-position), so the expected
failures are while we wait for removal in M68.

BUG=804187

Change-Id: Ifcaa72f42f2b63730ec761bf4fff4d4557f82b75
Reviewed-on: https://chromium-review.googlesource.com/897071
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533849}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-897071 branch from 92961fd to 17cb568 Feb 1, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f4eae05 into master Feb 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-897071 branch Feb 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.