Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] Allow alignment of in-flow items with non-static positions #9350

Merged
merged 1 commit into from Feb 2, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 1, 2018

This is a fix for a regression introduced in r515391, where we landed
the implementation of alignment for positioned objects in a Grid Layout
container.

We assumed that items with non-static positions shouldn't honor the
CSS Box Alignment properties. This is only true for out-of-flow items,
absolute or fixed positioned elements. However, sticky positioned
elements are treated as relative positioned items, but they indeed use
non-static position to define their behavior.

Bug: 806622
Change-Id: Ibaed2c36530d81223d1491def9022e82cf9c3525
Reviewed-on: https://chromium-review.googlesource.com/897949
Commit-Queue: Javier Fernandez jfernandez@igalia.com
Reviewed-by: Manuel Rego Casasnovas rego@igalia.com
Reviewed-by: Christian Biesinger cbiesinger@chromium.org
Cr-Commit-Position: refs/heads/master@{#534029}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 1, 2018

Build PASSED

Started: 2018-02-02 12:47:26
Finished: 2018-02-02 12:57:38

Failing Jobs

  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-897949 branch 2 times, most recently from 6347eb9 to 7b7403b Feb 2, 2018

[css-grid] Allow alignment of in-flow items with non-static positions
This is a fix for a regression introduced in r515391, where we landed
the implementation of alignment for positioned objects in a Grid Layout
container.

We assumed that items with non-static positions shouldn't honor the
CSS Box Alignment properties. This is only true for out-of-flow items,
absolute or fixed positioned elements. However, sticky positioned
elements are treated as relative positioned items, but they indeed use
non-static position to define their behavior.

Bug: 806622
Change-Id: Ibaed2c36530d81223d1491def9022e82cf9c3525
Reviewed-on: https://chromium-review.googlesource.com/897949
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534029}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-897949 branch from 7b7403b to f98d13f Feb 2, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 99a478a into master Feb 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-897949 branch Feb 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.