Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mojo Blob URLs] Resolve navigation blob URLs in blink. #9353

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 2, 2018

This makes sure that no race conditions exist between navigating to a
blob URL and revoking it. Currently only implemented for the network
service code path.

Also add one more navigation-then-revoke WPT test, as the existing tests
didn't cover the NavigationScheduler code-path.

Design doc: https://docs.google.com/document/d/1DqVcTWE9Qb_3KpIRH2bFV-6hWEr8S92c4ppY67YL1KI/edit#heading=h.n4fzuc6mgziv

Further navigation cases are handled in https://chromium-review.googlesource.com/c/chromium/src/+/899508.

Bug: 800901
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Icf9a4725526b4329a2841626977292802ad2fa7a
Reviewed-on: https://chromium-review.googlesource.com/898009
Reviewed-by: Daniel Cheng dcheng@chromium.org
Reviewed-by: Kinuko Yasuda kinuko@chromium.org
Reviewed-by: Nasko Oskov nasko@chromium.org
Commit-Queue: Marijn Kruisselbrink mek@chromium.org
Cr-Commit-Position: refs/heads/master@{#547842}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 2, 2018

Build PASSED

Started: 2018-04-03 22:03:57
Finished: 2018-04-03 22:10:04

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-898009 branch 7 times, most recently from b712338 to 1d4bc3a Feb 2, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-898009 branch 4 times, most recently from 5125979 to 2bc9732 Feb 12, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-898009 branch from 2bc9732 to 923bb9c Feb 22, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-898009 branch 5 times, most recently from 1f2d9f0 to f0402d7 Mar 22, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-898009 branch 3 times, most recently from 36d0a89 to 3d2e20e Mar 30, 2018

[Mojo Blob URLs] Resolve navigation blob URLs in blink.
This makes sure that no race conditions exist between navigating to a
blob URL and revoking it. Currently only implemented for the network
service code path.

Also add one more navigation-then-revoke WPT test, as the existing tests
didn't cover the NavigationScheduler code-path.

Design doc: https://docs.google.com/document/d/1DqVcTWE9Qb_3KpIRH2bFV-6hWEr8S92c4ppY67YL1KI/edit#heading=h.n4fzuc6mgziv

Further navigation cases are handled in https://chromium-review.googlesource.com/c/chromium/src/+/899508.

Bug: 800901
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Icf9a4725526b4329a2841626977292802ad2fa7a
Reviewed-on: https://chromium-review.googlesource.com/898009
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547842}

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9921476 into master Apr 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-898009 branch Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.