Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AbortController and AbortSignal #9361

Merged
merged 1 commit into from Feb 5, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 2, 2018

Also adjust layout tests expectations to match the new behaviour. One
fetch() wpt test that previously failed due to AbortController being
undefined now times out because the "signal" properties in fetch options
doesn't do anything yet. This will be fixed once it is implemented.

Spec: https://dom.spec.whatwg.org/#aborting-ongoing-activities
Design doc: https://docs.google.com/document/d/1OuoCG2uiijbAwbCw9jaS7tHEO0LBO_4gMNio1ox0qlY/edit
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/9vNZh4fhV2U/ZVxD2iQACgAJ

BUG=750599

Change-Id: I0e504bbf7f8552d602913ee2069bbf90f95deaff
Reviewed-on: https://chromium-review.googlesource.com/896669
Commit-Queue: Adam Rice ricea@chromium.org
Reviewed-by: Kent Tamura tkent@chromium.org
Reviewed-by: Hayato Ito hayato@chromium.org
Reviewed-by: Joshua Bell jsbell@chromium.org
Cr-Commit-Position: refs/heads/master@{#534352}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 2, 2018

Build PASSED

Started: 2018-02-05 09:31:02
Finished: 2018-02-05 09:40:03

Failing Jobs

  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-896669 branch 3 times, most recently from 2e4b6f9 to 6e18c41 Feb 2, 2018

Implement AbortController and AbortSignal
Also adjust layout tests expectations to match the new behaviour. One
fetch() wpt test that previously failed due to AbortController being
undefined now times out because the "signal" properties in fetch options
doesn't do anything yet. This will be fixed once it is implemented.

Spec: https://dom.spec.whatwg.org/#aborting-ongoing-activities
Design doc: https://docs.google.com/document/d/1OuoCG2uiijbAwbCw9jaS7tHEO0LBO_4gMNio1ox0qlY/edit
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/9vNZh4fhV2U/ZVxD2iQACgAJ

BUG=750599

Change-Id: I0e504bbf7f8552d602913ee2069bbf90f95deaff
Reviewed-on: https://chromium-review.googlesource.com/896669
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534352}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-896669 branch from 6e18c41 to 6fd9710 Feb 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7caa3de into master Feb 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-896669 branch Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.