Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove extra form data, if "value" attribute present with non-empty value" #9362

Merged
merged 1 commit into from Feb 2, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 2, 2018

This reverts commit 9b477bcaea5558d93d9d6aadc6674181bd00aab1.

Reason for revert: We should deprecate the feature first.

Original change's description:

Remove extra form data, if "value" attribute present with non-empty value

This patch removes the extra form data added, if "value" attribute
present with non-empty value for

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hp1_-1tgvDs

Bug: 753746
Change-Id: I1de9a0c9babd9d16b45e5eefa780370fff8c75e9
Reviewed-on: https://chromium-review.googlesource.com/896905
Reviewed-by: Kent Tamura tkent@chromium.org
Commit-Queue: Shanmuga Pandi shanmuga.m@samsung.com
Cr-Commit-Position: refs/heads/master@{#533655}

TBR=tkent@chromium.org,foolip@chromium.org,shanmuga.m@samsung.com

Change-Id: I97c5987adba9eaa097808f7a35c54859217edd2e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 753746
Reviewed-on: https://chromium-review.googlesource.com/897264
Reviewed-by: Kent Tamura tkent@chromium.org
Commit-Queue: Kent Tamura tkent@chromium.org
Cr-Commit-Position: refs/heads/master@{#533910}

Revert "Remove extra form data, if "value" attribute present with non…
…-empty value"

This reverts commit 9b477bcaea5558d93d9d6aadc6674181bd00aab1.

Reason for revert: We should deprecate the feature first.

Original change's description:
> Remove extra form data, if "value" attribute present with non-empty value
>
> This patch removes the extra form data added, if "value" attribute
> present with non-empty value for <input type='image'>
>
> Intent to Deprecate and Remove:
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hp1_-1tgvDs
>
> Bug: 753746
> Change-Id: I1de9a0c9babd9d16b45e5eefa780370fff8c75e9
> Reviewed-on: https://chromium-review.googlesource.com/896905
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
> Cr-Commit-Position: refs/heads/master@{#533655}

TBR=tkent@chromium.org,foolip@chromium.org,shanmuga.m@samsung.com

Change-Id: I97c5987adba9eaa097808f7a35c54859217edd2e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 753746
Reviewed-on: https://chromium-review.googlesource.com/897264
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533910}
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit b4dd35c into master Feb 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-f591d29ef7 branch Feb 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 2, 2018

Build PASSED

Started: 2018-02-02 12:41:38
Finished: 2018-02-02 12:46:53

View more information about this build on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.