Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] throw RangeError when divide-by-zero #9363

Merged
merged 1 commit into from Feb 3, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 2, 2018

when we invert a CSSUnitValue with 0 value,
we should throw a RangeError.
present, we are used std::transform to get inverted values.
when some values makes RangeError in a loop,
we don't need to calcuate remaining values which not inverted.

Bug: 807006
Change-Id: I443bb032e29b0ad0f8bbb872ae9bfdc5877255f6
Reviewed-on: https://chromium-review.googlesource.com/893020
Commit-Queue: Hwanseung Lee hs1217.lee@samsung.com
Reviewed-by: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#534264}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 2, 2018

Build PASSED

Started: 2018-02-03 07:28:59
Finished: 2018-02-03 07:32:38

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-893020 branch 2 times, most recently from a7d8a06 to 0095998 Feb 3, 2018

[css-typed-om] throw RangeError when divide-by-zero
when we invert a CSSUnitValue with 0 value,
we should throw a RangeError.
present, we are used std::transform to get inverted values.
when some values makes RangeError in a loop,
we don't need to calcuate remaining values which not inverted.

Bug: 807006
Change-Id: I443bb032e29b0ad0f8bbb872ae9bfdc5877255f6
Reviewed-on: https://chromium-review.googlesource.com/893020
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534264}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-893020 branch from 0095998 to ab26b32 Feb 3, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 2a93e5f into master Feb 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-893020 branch Feb 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.