Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Picture-in-Picture] Add PictureInPictureWindow width and height stubs #9370

Merged
merged 1 commit into from Feb 13, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 2, 2018

This introduces PictureInPictureWindow interface with |width| and
|height| attributes. |onresize| event will follow in an upcoming CL.
|width| and |height| simply return fake values, respectively 500 and
300, for now as we don't have any resize events coming from the backend
yet. They are reset to 0 though when PictureInPictureWindow state is
closed.

Bug: 806249
Change-Id: I5e0f0875a53b7f659bc3469e562d3db5e075f31d
Reviewed-on: https://chromium-review.googlesource.com/899347
Commit-Queue: Mounir Lamouri mlamouri@chromium.org
Reviewed-by: Mounir Lamouri mlamouri@chromium.org
Reviewed-by: apacible apacible@chromium.org
Cr-Commit-Position: refs/heads/master@{#536520}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 2, 2018

Build PASSED

Started: 2018-02-13 22:50:15
Finished: 2018-02-13 22:56:29

Failing Jobs

  • chrome:dev

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-899347 branch 4 times, most recently from 3f6d20a to 2bca98a Feb 2, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [Picture-in-Picture] Add PictureInPictureWindow width and height [Picture-in-Picture] Expose PictureInPictureWindow width and height stubs Feb 7, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-899347 branch 4 times, most recently from 26b0d6f to 839f61f Feb 7, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [Picture-in-Picture] Expose PictureInPictureWindow width and height stubs [Picture-in-Picture] Add PictureInPictureWindow width and height stubs Feb 9, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-899347 branch 7 times, most recently from d92a021 to 70fa4cf Feb 9, 2018

[Picture-in-Picture] Add PictureInPictureWindow width and height stubs
This introduces PictureInPictureWindow interface with |width| and
|height| attributes. |onresize| event will follow in an upcoming CL.
|width| and |height| simply return fake values, respectively 500 and
300, for now as we don't have any resize events coming from the backend
yet. They are reset to 0 though when PictureInPictureWindow state is
closed.

Bug: 806249
Change-Id: I5e0f0875a53b7f659bc3469e562d3db5e075f31d
Reviewed-on: https://chromium-review.googlesource.com/899347
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536520}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-899347 branch from 70fa4cf to 485fd8a Feb 13, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e9ffe0b into master Feb 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-899347 branch Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.