Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Picture-in-Picture] Show/hide PiP button when appropriate #9372

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

commented Feb 2, 2018

Bug: 726621
Change-Id: Idaf5eda9f55354fb2eac25eee74f2dacc4c65b2c

Reviewed-on: https://chromium-review.googlesource.com/897322
WPT-Export-Revision: eaef8d9eb14933f4fe5cb5f3ad7c73a7394bd197

[Picture-in-Picture] Show/hide PiP button when appropriate
Bug: 726621
Change-Id: Idaf5eda9f55354fb2eac25eee74f2dacc4c65b2c
@wpt-pr-bot
Copy link
Collaborator

left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

commented Feb 2, 2018

Build PASSED

Started: 2018-02-02 21:50:03
Finished: 2018-02-02 22:01:47

Failing Jobs

  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/picture-in-picture/enter-picture-in-picture.html   TIMEOUT: 1
ERROR: 9
  Test enterpictureinpicture event TIMEOUT: 9
Test timed out
@csnardi

This comment has been minimized.

Copy link
Member

commented Jun 4, 2018

Same as in #9371, this change wasn't intentional, and the CL landed without it, so closing this PR.

@csnardi csnardi closed this Jun 4, 2018

@csnardi csnardi deleted the chromium-export-cl-897322 branch Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.