Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cssom] Add test for synchronization between css declaration block and style attribute #9376

Merged
merged 2 commits into from Feb 11, 2018

Conversation

Projects
None yet
4 participants
@upsuper
Copy link
Member

upsuper commented Feb 4, 2018

This is test for proposed spec change in w3c/csswg-drafts#2269.

@upsuper

This comment has been minimized.

Copy link
Member Author

upsuper commented Feb 4, 2018

Currently, Firefox fails one test that it generates mutation record even when removing non-existing property from the CSS declaration block. We are going to fix this in Gecko bug 1435139.

WebKit and Blink both fail a test that they don't generate mutation record when setting the same value to CSS declaration block. Based on my reasoning in w3c/csswg-drafts#2269 (comment), I tend to keep the proposed behavior as-is, and ask those browsers to change their behavior here.

WebKit fails another test in addition that it doesn't clear the declaration block when the style attribute is removed. This is definitely a bug for them should be fixed.

I haven't tested Edge because I'm not using my Windows laptop at the moment.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 4, 2018

Build PASSED

Started: 2018-02-11 22:32:02
Finished: 2018-02-11 22:36:18

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@upsuper

This comment has been minimized.

Copy link
Member Author

upsuper commented Feb 5, 2018

Hmmm, after fixing that issue, Gecko will fail the same test as Blink :/

(The test itself matches the proposed spec change, but we may want to decide what should we do for setProperty.)

@upsuper upsuper force-pushed the upsuper:css-style-attr-decl-block branch from 5df2b0a to a80c55c Feb 5, 2018

@zcorpan

This comment has been minimized.

Copy link
Contributor

zcorpan commented Feb 11, 2018

I added a commit to test
w3c/csswg-drafts@03cef6e
by testing what bz suggested in
w3c/csswg-drafts#1559 (comment)

@upsuper upsuper merged commit c81c644 into web-platform-tests:master Feb 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@upsuper upsuper deleted the upsuper:css-style-attr-decl-block branch Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.