Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Add per-property tests. #9383

Merged
merged 1 commit into from Feb 6, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 4, 2018

Currently, we don't have any test coverage over properties. In our
existing tests, we only use 'canonical' test properties like 'width'.
This means that it's possible that other properties (e.g. 'height')
might not work and we still pass the tests.

We add a bunch of new files, each representing a property. Think of
these as metadata for the properties. For example, each file contains
the values that are valid for that property. We then have a test suite
that uses this metadata to generate appropriate tests.

More properties will be coming.

There is a test failure involving setting margin-top to unitless zero.

Bug: 774887
Change-Id: I8f8463c8f608454ef177e81ace21fe1eeb66f897
Reviewed-on: https://chromium-review.googlesource.com/882901
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#534623}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 4, 2018

Build PASSED

Started: 2018-02-06 04:49:25
Finished: 2018-02-06 04:54:46

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-882901 branch 2 times, most recently from 768078b to 985690e Feb 5, 2018

[css-typed-om] Add per-property tests.
Currently, we don't have any test coverage over properties. In our
existing tests, we only use 'canonical' test properties like 'width'.
This means that it's possible that other properties (e.g. 'height')
might not work and we still pass the tests.

We add a bunch of new files, each representing a property. Think of
these as metadata for the properties. For example, each file contains
the values that are valid for that property. We then have a test suite
that uses this metadata to generate appropriate tests.

More properties will be coming.

There is a test failure involving setting margin-top to unitless zero.

Bug: 774887
Change-Id: I8f8463c8f608454ef177e81ace21fe1eeb66f897
Reviewed-on: https://chromium-review.googlesource.com/882901
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534623}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-882901 branch from 985690e to 280e0aa Feb 6, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7b7b881 into master Feb 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-882901 branch Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.