Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dom_override_remove_cue_while_paused.html #9385

Merged
merged 1 commit into from Feb 5, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 5, 2018

The failure looks to be because of the difference in screenshots.
The test has a white background video, where as the reftest has a
div element. Adding same video instead of div in reftest also
to pass the test.

Bug: 774567
Change-Id: I2b616df29c74f449dcce04e3e7c83da9c61427a3
Reviewed-on: https://chromium-review.googlesource.com/896734
Reviewed-by: Fredrik Söderquist fs@opera.com
Commit-Queue: srirama chandra sekhar srirama.m@samsung.com
Cr-Commit-Position: refs/heads/master@{#534365}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 5, 2018

Build PASSED

Started: 2018-02-05 11:45:48
Finished: 2018-02-05 11:50:36

Failing Jobs

  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/webvtt/rendering/cues-with-video/processing-model/dom_override_remove_cue_while_paused.html   TIMEOUT: 2
PASS: 8
Fix dom_override_remove_cue_while_paused.html
The failure looks to be because of the difference in screenshots.
The test has a white background video, where as the reftest has a
div element. Adding same video instead of div in reftest also
to pass the test.

Bug: 774567
Change-Id: I2b616df29c74f449dcce04e3e7c83da9c61427a3
Reviewed-on: https://chromium-review.googlesource.com/896734
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#534365}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-896734 branch from a0e6de3 to 8ba9144 Feb 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 58bd5c5 into master Feb 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-896734 branch Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.