Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Picture-in-Picture] Add Shadow DOM support for pictureInPictureElement #9387

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 5, 2018

Until now, pictureInPictureElement was supported only in Document. This
CL makes it compliant with the spec by adding Shadow DOM support to
pictureInPictureElement. Note that I wish I could have used a partial
interface DocumentOrShadowRoot but partial interface for mix-in IDL are
not supported at that time (crbug.com/656517).

Bug: 806249, 656517
Change-Id: I5f9666ea9c52ded9a6d07a238fc7756371b7550e
Reviewed-on: https://chromium-review.googlesource.com/897513
Commit-Queue: Mounir Lamouri mlamouri@chromium.org
Reviewed-by: apacible apacible@chromium.org
Reviewed-by: Hayato Ito hayato@chromium.org
Reviewed-by: Mounir Lamouri mlamouri@chromium.org
Reviewed-by: Kentaro Hara haraken@chromium.org
Cr-Commit-Position: refs/heads/master@{#535747}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 5, 2018

Build PASSED

Started: 2018-02-09 18:15:25
Finished: 2018-02-09 18:21:29

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-897513 branch 6 times, most recently from e414399 to f66fbca Feb 5, 2018

[Picture-in-Picture] Add Shadow DOM support for pictureInPictureElement
Until now, pictureInPictureElement was supported only in Document. This
CL makes it compliant with the spec by adding Shadow DOM support to
pictureInPictureElement. Note that I wish I could have used a partial
interface DocumentOrShadowRoot but partial interface for mix-in IDL are
not supported at that time (crbug.com/656517).

Bug: 806249, 656517
Change-Id: I5f9666ea9c52ded9a6d07a238fc7756371b7550e
Reviewed-on: https://chromium-review.googlesource.com/897513
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535747}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-897513 branch from f66fbca to 465e2a5 Feb 9, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 92d4935 into master Feb 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-897513 branch Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.