Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test window.opener's binding #9390

Merged
merged 2 commits into from Feb 5, 2018

Conversation

Projects
None yet
4 participants
@annevk
Copy link
Member

annevk commented Feb 5, 2018

Inspired by whatwg/html#3448.

@wpt-pr-bot wpt-pr-bot added the html label Feb 5, 2018

@wpt-pr-bot wpt-pr-bot requested review from jdm, jgraham and zqzhang Feb 5, 2018

@annevk annevk requested a review from bzbarsky Feb 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 5, 2018

Build PASSED

Started: 2018-02-05 17:47:52
Finished: 2018-02-05 17:56:37

View more information about this build on:

[],
Symbol()
].forEach(val => {
const title = typeof val === "symbol" ? "Symbol" : String(val);

This comment has been minimized.

Copy link
@bzbarsky

bzbarsky Feb 5, 2018

Contributor

String(Symbol()) works too, so you could just set title to String(val) unconditionally.

@annevk annevk merged commit bb1f351 into master Feb 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the annevk/window-opener-setter branch Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.