Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure testharnessreport.js is loaded as utf8 #9393

Merged
merged 2 commits into from Feb 28, 2018

Conversation

Projects
None yet
4 participants
@jgraham
Copy link
Contributor

jgraham commented Feb 5, 2018

This change is Reviewable

Ensure testharnessreport.js is loaded as utf8
MozReview-Commit-ID: C5E7to91rFU

@wpt-pr-bot wpt-pr-bot added the infra label Feb 5, 2018

@wpt-pr-bot wpt-pr-bot requested a review from gsnedders Feb 5, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Feb 5, 2018

@jgraham

This comment has been minimized.

Copy link
Contributor Author

jgraham commented Feb 5, 2018

Because a StaticHandler doesn't look at the .headers file, only a a FileHandler does. Maybe things should change so that .headers are applied to the URL rather than the fs path, but that is a big change and this is a one-line change.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 5, 2018

Build BROKEN

Started: 2018-02-23 18:44:31
Finished: 2018-02-23 18:58:13

Failing Jobs

  • resources_unittest in py27

View more information about this build on:

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Feb 5, 2018

@jgraham Can you add a comment to that effect so I don't end up confused several years down the line?

@wpt-pr-bot wpt-pr-bot requested a review from ayg Feb 5, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Feb 6, 2018

@jgraham do we actually want to mark them as immutable? they might change, they aren't actually immutable.

@jgraham

This comment has been minimized.

Copy link
Contributor Author

jgraham commented Feb 6, 2018

It would certainly be fine on implementations where we have a separate profile per run. AIUI it only means we don't revalidate on reload so maybe it's not worthwhile, and actually it turns out to not work in firefox except over https so it's probably not worthwhile.

@jgraham jgraham force-pushed the testharnessreport_utf8 branch from 392cf2c to 73d12e2 Feb 6, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Feb 7, 2018

Can you reword the commit message for the second commit on the branch, given it's now totally wrong? :)

Ensure that static assets are cached.
Give them a max-age of 1 hour and ensure that the cache-control header
is also applied with the StaticHandler used in wptrunner.

@jgraham jgraham force-pushed the testharnessreport_utf8 branch from 73d12e2 to 7b00f62 Feb 23, 2018

@gsnedders gsnedders merged commit fa24b4a into master Feb 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the testharnessreport_utf8 branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.