Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a pointerlock test #9398

Merged
merged 1 commit into from Feb 6, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 5, 2018

This CL update the wpt test pointerevent_pointerlock_after_pointercapture.

Previously this test request pointer lock on pointermove, it got a
pointerlockerror event because it doesn't request the lock in a user gesture.
This CL change the test to send lock request by a right click.

Bug: 805052
Change-Id: I27b60475ccda94ca59e018ab76550379bc3852e4
Reviewed-on: https://chromium-review.googlesource.com/902450
Reviewed-by: Navid Zolghadr nzolghadr@chromium.org
Commit-Queue: Ella Ge eirage@chromium.org
Cr-Commit-Position: refs/heads/master@{#534689}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 5, 2018

Build PASSED

Started: 2018-02-06 15:35:25
Finished: 2018-02-06 15:46:44

View more information about this build on:

Update a pointerlock test
This CL update the wpt test pointerevent_pointerlock_after_pointercapture.

Previously this test request pointer lock on pointermove, it got a
pointerlockerror event because it doesn't request the lock in a user gesture.
This CL change the test to send lock request by a right click.

Bug: 805052
Change-Id: I27b60475ccda94ca59e018ab76550379bc3852e4
Reviewed-on: https://chromium-review.googlesource.com/902450
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534689}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-902450 branch from 6da24dd to fa3730c Feb 6, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 52f1485 into master Feb 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-902450 branch Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.